luci-mod-network: put each IPv6 address on a separate line #6895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, when there's active DHCPv6 leases and more than one address per host (e.g. because ULA is used together with GUA prefixes), the two IPv6 addresses will be printed on one line (which may or may not get broken up depending on the length of the addresses, which also looks inconsistent). Putting each address on a separate line makes it much easier to read the addresses (IMHO). Signed-off-by: David Härdeman <david@hardeman.nu>
|
Good - thank you. |
@systemcrash great, thanks. Any chance this could be cherry-picked for the 23.05 branch as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when there's active DHCPv6 leases and more than one address per host (e.g. because ULA is used together with GUA prefixes), the two IPv6 addresses will be printed on one line (which may or may not get broken up depending on the length of the addresses, which also looks inconsistent).
Putting each address on a separate line makes it much easier to read the addresses (IMHO).