luci-base: Display 'Access Point' in the wireless page instead of 'Master' #6755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanTheB
force-pushed
the
modemaster
branch
3 times, most recently
from
7674ec0 to
d01b519
Compare
|
Please remap the i18n label only but don't change the internal value. |
|
Thanks jow, I have changed to modify only the I18n variant. I could not work out what the getActiveMode function is used for, all the usages seem to be user facing strings, so I'm not sure why the I18n variant is not used everywhere. Would you accept a patch changing all usage to the I18n variant? Thanks |
systemcrash
requested changes
Dec 12, 2023
stokito
approved these changes
Dec 12, 2023
uci mesh was being displayed as 'Mesh', while iwinfo mesh was being reported as 'Mesh Point'. Unify those. Update getActiveModeI18n to deal with all the values iwinfo returns. Fix the incorrect 'Mash' translation. Signed-off-by: Evan Benn <evan.benn@morsemicro.com>
Access Point is the string used on the network wireless setup dialogue. Use Access Point to report the mode on the network wireless and status screens. Signed-off-by: Evan Benn <evan.benn@morsemicro.com>
Signed-off-by: Evan Benn <evan.benn@morsemicro.com>
systemcrash
approved these changes
Dec 17, 2023
systemcrash
added a commit
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Evan Benn <evan.benn@morsemicro.com> luci-base: Display 'Access Point' in the wireless page instead of 'Master' (cherry picked from commit c3fc80c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config dialogue uses "Access Point".
Fix up a missed translation and some other minor issues.