Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-sqm: Use CAKE as default qdisc #4702

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

tohojo
Copy link
Contributor

@tohojo tohojo commented Dec 31, 2020

The sqm-scripts package depends on kmod-sched-cake, meaning CAKE is always
available in normal installs. So we might as well just make CAKE the
default config in SQM configs.

The sqm-scripts package depends on kmod-sched-cake, meaning CAKE is always
available in normal installs. So we might as well just make CAKE the
default config in SQM configs.

Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
@hnyman
Copy link
Contributor

hnyman commented Dec 31, 2020

Like I commented in tohojo/sqm-scripts#130 (comment)
the actual deafult in SQM in OpenWrt is still simple/fq_codel

This PR needs to wait until you have changed the SQM itself to have cake as default in OpenWrt.

@hnyman hnyman added the depends on other pr pull request depends on another pull request label Dec 31, 2020
@tohojo
Copy link
Contributor Author

tohojo commented Dec 31, 2020

Updated sqm-scripts with openwrt/packages@2c65212 - merging this as well.

And happy new year! :)

@tohojo tohojo merged commit 96b8f43 into openwrt:master Dec 31, 2020
@hnyman
Copy link
Contributor

hnyman commented Dec 31, 2020

@tohojo
You forgot to update PKG_MIRROR_HASH in openwrt/packages@2c65212

It still has the hash git .tar.xz of git clone of the previous version on line 17

(you did right the previous time, with openwrt/packages@1126368 )

@tohojo
Copy link
Contributor Author

tohojo commented Dec 31, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on other pr pull request depends on another pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants