Fix phonetics for 麼 #597
Merged
Fix phonetics for 麼 #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concise dictionary prefers `麼 ㄇㄜ˙`. Ensure both `ㄇㄜ˙` and `ㄇㄛ˙` are present. Ensure variants for: ``` 什麼 ㄕㄜˊ ㄇㄛ˙ 什麼 ㄕㄜˊ ㄇㄜ˙ 什麼 ㄕㄣˊ ㄇㄛ˙ 什麼 ㄕㄣˊ ㄇㄜ˙ 怎麼 ㄗㄜˇ ㄇㄛ˙ 怎麼 ㄗㄜˇ ㄇㄜ˙ 怎麼 ㄗㄣˇ ㄇㄛ˙ 怎麼 ㄗㄣˇ ㄇㄜ˙ 甚麼 ㄕㄜˊ ㄇㄛ˙ 甚麼 ㄕㄜˊ ㄇㄜ˙ 甚麼 ㄕㄣˊ ㄇㄛ˙ 甚麼 ㄕㄣˊ ㄇㄜ˙ 這麼 ㄓㄜˋ ㄇㄛ˙ 這麼 ㄓㄜˋ ㄇㄜ˙ 那麼 ㄋㄚˋ ㄇㄛ˙ 那麼 ㄋㄚˋ ㄇㄜ˙ ``` Remove the following variants: ``` 什麼 ㄕˊ ㄇㄜ˙ 什麼 ㄕㄜˊ ㄇㄛˊ ``` Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E9%BA%BC#searchL
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- Source/Data/BPMFMappings.txt: Language not supported
- Source/Data/phrase.occ: Language not supported
|
|
@lukhnos this is a tricky one, I believe this should be the best approach for consistency, but please let me know if you have any suggestions. |
ChiahongHong
reviewed
Feb 9, 2025
Comment on lines
-34252
to
+34283
| 報什麼蟲 ㄅㄠˋ ㄕˊ ㄇㄜ˙ ㄔㄨㄥˊ | ||
| 報什麼蟲 ㄅㄠˋ ㄕㄜˊ ㄇㄛ˙ ㄔㄨㄥˊ | ||
| 報什麼蟲 ㄅㄠˋ ㄕㄜˊ ㄇㄜ˙ ㄔㄨㄥˊ | ||
| 報什麼蟲 ㄅㄠˋ ㄕㄣˊ ㄇㄛ˙ ㄔㄨㄥˊ | ||
| 報什麼蟲 ㄅㄠˋ ㄕㄣˊ ㄇㄜ˙ ㄔㄨㄥˊ |
There was a problem hiding this comment.
I'm really curious about how this phrase was originally included 🤣
Is it from some kind of game or a sci-fi character or something? It makes absolutely no sense XDD
Or maybe it was supposed to be 報什麼仇, but someone just made a typo?
There was a problem hiding this comment.
yeah, I noticed this funny one, too. lol
There was a problem hiding this comment.
This might have been my lack of editing effort on contributed suggestion at the time. Thanks for pointing it out. <3
There was a problem hiding this comment.
@ChiahongHong @mjhsieh as this PR has been merged, we can keep it as-is, or propose another PR for 報什麼仇 or the deletion of this entry.
There was a problem hiding this comment.
我覺得留著也很好。總有一天有人會需要寫下列例句：「這家公司的軟體臭蟲越來越多，辛苦回報也都被標以不修或無法重現打回，讓人不禁懷疑，他們主管是不是都以『報什麼蟲啊！』的心態在對待每週彙報。」
lukhnos
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
LGTM. Thanks!
At first I was concerned with the removals for 什麼 ㄕˊ ㄇㄜ˙ and 什麼 ㄕㄜˊ ㄇㄛˊ, but looking at the diff, I realized that this only removes .+什麼, 什麼.+ or .+什麼.+ without touching the standalone entries for ^什麼$.
Given the very small amount of deletions it appears that those reading must have been included by some mistake or at least some quirks. I'm comfortable with those deletions.
|
Yup, that's precisely what I thought when authoring this PR. I took the route to maintain the consistency with small number of deletions. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concise dictionary prefers
麼 ㄇㄜ˙.Ensure both
ㄇㄜ˙andㄇㄛ˙are present.Ensure variants for:
Remove the following variants:
Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E9%BA%BC#searchL