Fix phonetics for 唧 #593
Fix phonetics for 唧 #593
Conversation
The concise dictionary prefers `唧 ㄐㄧˊ`. Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%94%A7#searchL
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- Source/Data/BPMFMappings.txt: Language not supported
|
@lukhnos PTAL, this should better handle the case. I typically fork off from upstream/master to fix characters respectively, hence merge conflicts may need to be handled manually. Please don't hesitate to ping me and I can address them by rebasing the 2nd PR on top of upstream tip once the 1st has been merged to master. Thanks again for reviewing/approving these PR series. 🙏 |
There was a problem hiding this comment.
I typically fork off from upstream/master to fix characters respectively, hence merge conflicts may need to be handled manually. Please don't hesitate to ping me and I can address them by rebasing the 2nd PR on top of upstream tip once the 1st has been merged to master. Thanks again for reviewing/approving these PR series. 🙏
No worries, and thanks for letting me know. As for #589, it was just that I thought I should leave a note for why it wasn't immediately merged, and a bit later I happened to have some spare time to resolve the conflicts myself. Thanks again for this series of PRs!
To better address merge conflict from #589.
As both 唧 and 喳 are updated from recent PRs.