Fix phonetics for 呱 #586
Merged
Fix phonetics for 呱 #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concise dictionary prefers `呱 ㄍㄨ`. The revised dictionary prefers `呱 ㄨㄚ` for the following: ```text 呱呱 ㄨㄚ ㄨㄚ 呱呱墮地 ㄨㄚ ㄨㄚ ㄉㄨㄛˋ ㄉㄧˋ 呱呱墜地 ㄨㄚ ㄨㄚ ㄓㄨㄟˋ ㄉㄧˋ ``` Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%91%B1#searchL https://dict.revised.moe.edu.tw/search.jsp?md=1&word=%E5%91%B1
lukhnos
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concise dictionary prefers
呱 ㄍㄨ.The revised dictionary prefers
呱 ㄨㄚfor the following:Ref:
https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%91%B1#searchL https://dict.revised.moe.edu.tw/search.jsp?md=1&word=%E5%91%B1
Summary by Bito
This pull request introduces phonetic updates for the character '呱', including new mappings in BPMFMappings.txt and an updated entry in phrase.occ. These changes enhance the accuracy of phonetic representations in the application.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and primarily involve updates to existing files, making the review process relatively simple.