Show custom size in Candidate Text Size setting #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this treatment, if a user uses a custom candidate text size, the pop up button will revert to the first item (the smallest font size) in the list since we now remove the empty item at the bottom. If the user doesn't touch the pop up button, the custom font size remains intact. It's still a less ideal UI, though. This commit makes sure that the custom font size is inserted into the pop up button and is selected.
zonble
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this treatment, if a user uses a custom candidate text size, the pop up button will revert to the first item (the smallest font size) in the list since we now remove the empty item at the bottom. If the user doesn't touch the pop up button, the custom font size remains intact. It's still a less ideal UI, though.
This commit makes sure that the custom font size is inserted into the pop up button and is selected.
Using
defaults write org.openvanilla.inputmethod.McBopomofo CandidateListTextSize -int 38to set the custom font size to 38pt, this is before:After: