Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace "Installation Successful" dialog with text in installer window #386

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

shuang886
Copy link
Contributor

At least in Sonoma, both the installer and System Settings pop a dialog when the installation completes:

Screenshot 2023-11-23 at 7 16 34 AM Screenshot 2023-11-23 at 7 16 44 AM

which seems distracting. This proposal replaces the installer dialog with some more sedate:

Screenshot 2023-11-23 at 8 56 01 AM

Copy link
Contributor

@lukhnos lukhnos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks again for the contribution.

This looks good. Just one missing @IBOutlet connection in the zh-Hant xib.

Source/Installer/zh-Hant.lproj/MainMenu.xib Show resolved Hide resolved
Copy link
Contributor

@lukhnos lukhnos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again!

@lukhnos lukhnos merged commit 76e1b04 into openvanilla:master Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants