-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdns] unify the behavior of Stop()
between avahi and mDNSResponder
#2725
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2725 +/- ##
===========================================
- Coverage 55.77% 45.21% -10.57%
===========================================
Files 87 108 +21
Lines 6890 13417 +6527
Branches 0 964 +964
===========================================
+ Hits 3843 6066 +2223
- Misses 3047 7025 +3978
- Partials 0 326 +326 ☔ View full report in Codecov by Sentry. |
VerifyOrExit(mState == State::kReady); | ||
|
||
mState = State::kIdle; | ||
mStateCallback(mState); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this callback be called after everything is cleared?
@@ -241,6 +241,9 @@ void PublisherMDnsSd::Stop(StopMode aStopMode) | |||
{ | |||
VerifyOrExit(mState == State::kReady); | |||
|
|||
mState = State::kIdle; | |||
mStateCallback(mState); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to clear states and then update the state and trigger callback?
In the
Stop()
method, thePublisher
will: