[mdns] check if the Publisher is ready in Register() and Unregister() for mDNSResponder
#2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superwhd
force-pushed
the
mdnsresponder-check-state
branch
from
f2a897e to
3f13c15
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2721 +/- ##
===========================================
- Coverage 55.77% 43.29% -12.49%
===========================================
Files 87 108 +21
Lines 6890 13401 +6511
Branches 0 963 +963
===========================================
+ Hits 3843 5802 +1959
- Misses 3047 7291 +4244
- Partials 0 308 +308 ☔ View full report in Codecov by Sentry. |
jwhui
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the comment: #2677 (comment)