Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: Dynamic route fallback #289

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[Platform]: Dynamic route fallback #289

merged 1 commit into from
Nov 16, 2023

Conversation

chinmehta
Copy link
Contributor

[Platform]: Dynamic route fallback

Fallback route added for drug, disease and target page. if any other route is added

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Issue: # opentargets/issues#3150
Deploy preview: (link)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A: try invalid route

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@chinmehta chinmehta requested a review from carcruz November 15, 2023 10:42
@carcruz carcruz merged commit 25cacc1 into main Nov 16, 2023
8 checks passed
@carcruz carcruz deleted the cm-route-fallback branch November 16, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants