Port components to ts 4 #2723
Open
Port components to ts 4 #2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
commented
Apr 1, 2025
| () => new Intl.DisplayNames([language], {type: 'language'}), | ||
| [language] | ||
| const text = React.useMemo( | ||
| () => (new Intl.DisplayNames([language], {type: 'language'})).of(locale), |
There was a problem hiding this comment.
We don't support browsers so old that Intl.DisplayNames isn't supported, so I took the fallback out.
jivey
reviewed
Apr 22, 2025
| @@ -41,7 +49,7 @@ export function Paginated({children, perPage=10}) { | |||
| } | |||
| useEffect(() => { | |||
| if (pageChanged) { | |||
| $.scrollTo(ref.current, 70); | |||
| $.scrollTo(ref.current as HTMLDivElement, 70); | |||
There was a problem hiding this comment.
Don't you want to check for current being set before calling this? I checked the helper and it doesn't check for a null param so it seems like this could cause issues...
There was a problem hiding this comment.
As I understand it, when the useEffect runs, the ref will be set, since it's set in the return value for the component. If I do a test for not-set, I won't be able to cover that branch with testing.
There was a problem hiding this comment.
I added an assertNotNull helper function.
RoyEJohnson
force-pushed
the
port-components-to-ts-4
branch
from
a8d3c58 to
9d295f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-857