Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit with make #204

Merged

Conversation

amolkahat
Copy link
Contributor

Updating pre-commit hook with make. pre-commit-golang repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

@amolkahat
Copy link
Contributor Author

/test openstack-operator-build-deploy

hack/pin-custom-bundle-dockerfile.sh Outdated Show resolved Hide resolved
@amolkahat
Copy link
Contributor Author

/test precommit-check

2 similar comments
@amolkahat
Copy link
Contributor Author

/test precommit-check

@Sandeepyadav93
Copy link
Contributor

/test precommit-check

@amolkahat amolkahat force-pushed the pre_commit_fix branch 2 times, most recently from a9c0368 to 85c25b8 Compare March 27, 2023 14:36
@bshewale
Copy link
Contributor

pre-commit result:

[bhagyashris@fedora openstack-operator]$ pre-commit run -a
golangci-lint............................................................Passed
gofmt....................................................................Passed
golint...................................................................Passed
govet....................................................................Passed
gotidy...................................................................Passed
make-manifests...........................................................Passed
make-generate............................................................Passed
make-operator-lint.......................................................Passed
check for added large files..............................................Passed
fix utf-8 byte order marker..............................................Passed
check for case conflicts.................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for merge conflicts................................................Passed
check for broken symlinks............................(no files to check)Skipped
detect destroyed symlinks................................................Passed
check yaml...............................................................Passed
check json...............................................................Passed
detect private key.......................................................Passed
fix end of files.........................................................Passed
don't commit to branch...................................................Passed
trim trailing whitespace.................................................Passed
bashate..................................................................Passed

Makefile Outdated Show resolved Hide resolved
@dprince
Copy link
Contributor

dprince commented Mar 28, 2023

looks fine to me, just the remaining question from abays

Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, amolkahat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit efb465a into openstack-k8s-operators:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants