-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pre-commit with make #204
Run pre-commit with make #204
Conversation
8772313
to
5c856e6
Compare
a6d1e67
to
3823620
Compare
/test openstack-operator-build-deploy |
3823620
to
413f49e
Compare
413f49e
to
09f64a5
Compare
09f64a5
to
2039e44
Compare
2039e44
to
d82e2a5
Compare
d82e2a5
to
71779f6
Compare
/test precommit-check |
2 similar comments
/test precommit-check |
/test precommit-check |
a9c0368
to
85c25b8
Compare
pre-commit result: [bhagyashris@fedora openstack-operator]$ pre-commit run -a |
looks fine to me, just the remaining question from abays |
Updating pre-commit hook with make. pre-commit-golang repo is no longer maintained[1]. Instead of using unmaintained repo we can use make to run pre-commit. [1] dnephin/pre-commit-golang#98
85c25b8
to
58208ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, amolkahat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updating pre-commit hook with make. pre-commit-golang repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.
[1] dnephin/pre-commit-golang#98