Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit hook with bashate #190

Closed
wants to merge 1 commit into from
Closed

Update pre-commit hook with bashate #190

wants to merge 1 commit into from

Conversation

amolkahat
Copy link
Contributor

This patch also inlucde bashate
fixes

@openshift-ci openshift-ci bot requested review from dprince and stuggi February 16, 2023 09:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amolkahat
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amolkahat
Copy link
Contributor Author

/retest

@abays
Copy link
Contributor

abays commented Feb 16, 2023

It looks likehack/create_self_signed_cert.sh needs to be updated as well to satisfy the new bash linting: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openstack-k8s-operators_openstack-operator/190/pull-ci-openstack-k8s-operators-openstack-operator-master-precommit-check/1626166885802315776#1:build-log.txt%3A103

@amolkahat
Copy link
Contributor Author

It looks likehack/create_self_signed_cert.sh needs to be updated as well to satisfy the new bash linting: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openstack-k8s-operators_openstack-operator/190/pull-ci-openstack-k8s-operators-openstack-operator-master-precommit-check/1626166885802315776#1:build-log.txt%3A103

Updated hack/create_self_signed_cert.sh. It should pass now.
Linting job also shows some permission denied error for golangci lint, this is also addressed here

@amolkahat
Update pre-commit hook with bashate
0577ecc 
This patch also inlucde bashate
fixes

Signed-off-by: Amol Kahat <amolkahat@gmail.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 20, 2023

@amolkahat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check 0577ecc link true /test precommit-check
ci/prow/openstack-operator-build-deploy 0577ecc link false /test openstack-operator-build-deploy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@amolkahat
Copy link
Contributor Author

/test precommit-check

@amolkahat
Copy link
Contributor Author

closing in favor of #204

@amolkahat amolkahat closed this Feb 23, 2023
@amolkahat amolkahat deleted the pre_commit_fixes branch February 23, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprince dprince Awaiting requested review from dprince

@stuggi stuggi Awaiting requested review from stuggi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amolkahat @abays @openshift-merge-robot