Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the steps required to add and remove a GlanceAPI #649

Merged

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Nov 6, 2024

No description provided.

@fmount fmount requested a review from konan-abhi November 6, 2024 11:06
@openshift-ci openshift-ci bot requested review from frenzyfriday and viroel November 6, 2024 11:06
@openshift-ci openshift-ci bot added the approved label Nov 6, 2024
@fmount fmount force-pushed the add-rm-api branch 3 times, most recently from 73d042f to c96c297 Compare November 6, 2024 11:12
Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount
Copy link
Contributor Author

fmount commented Nov 6, 2024

/test precommit-check

Copy link
Contributor

@konan-abhi konan-abhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link
Contributor

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, konan-abhi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c0c0828 into openstack-k8s-operators:main Nov 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants