Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-50634: [release-4.16] mlx fw reset #1056

Open
wants to merge 2 commits into
base: release-4.16
Choose a base branch
from
Open

OCPBUGS-50634: [release-4.16] mlx fw reset #1056

wants to merge 2 commits into from

Conversation

SchSeba
Copy link
Contributor

@SchSeba SchSeba commented Feb 12, 2025

No description provided.

@tobiasgiese @SchSeba
feat: implement MlxResetFW to reset the FW on VF changes
df16d29 
Signed-off-by: Tobias Giese <tgiese@nvidia.com>
@tobiasgiese @SchSeba
chore: add feature flag for mellanox fw reset
172d04e 
To not enable the new feature by default we want to add a feature flag first.

Signed-off-by: Tobias Giese <tgiese@nvidia.com>
@SchSeba
Copy link
Contributor Author

SchSeba commented Feb 12, 2025

/jira cherrypick OCPBUGS-49802

@openshift-ci-robot
Copy link
Contributor

@SchSeba: Jira Issue OCPBUGS-49802 has been cloned as Jira Issue OCPBUGS-50634. Will retitle bug to link to clone.
/retitle OCPBUGS-50634: [release-4.16] mlx fw reset

In response to this:

/jira cherrypick OCPBUGS-49802

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.16] mlx fw reset OCPBUGS-50634: [release-4.16] mlx fw reset Feb 12, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 12, 2025
@openshift-ci-robot
Copy link
Contributor

@SchSeba: This pull request references Jira Issue OCPBUGS-50634, which is invalid:

  • expected dependent Jira Issue OCPBUGS-49802 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@SchSeba
Copy link
Contributor Author

SchSeba commented Feb 17, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@SchSeba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-config-drive 172d04e link false /test e2e-openstack-nfv-config-drive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@evgenLevin
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1061123 s1061123 Awaiting requested review from s1061123

@SalDaniele SalDaniele Awaiting requested review from SalDaniele

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SchSeba @openshift-ci-robot @evgenLevin @tobiasgiese