Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-4884: Attributes for OADP 1.4.3 #88238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OADP-4884: Attributes for OADP 1.4.3 #88238

wants to merge 1 commit into from

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Feb 7, 2025 •
edited
Loading

JIRA

VERSIONS

  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18

PREVIEWS

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references OADP-4884 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 7, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 7, 2025 •
edited
Loading

🤖 Sat Feb 08 03:04:05 - Prow CI generated the docs preview:
https://88238--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@anarnold97 anarnold97 force-pushed the oadp-4884-attributes-update-OADP-1.4.3 branch from 71e58b2 to 0fa3403 Compare February 7, 2025 19:24
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references OADP-4884 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

VERSIONS

  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18

PREVIEWS

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97
Copy link
Contributor Author

/label oadp

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Feb 7, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2025
@anarnold97
OADP-4884: Attributes for OADP 1.4.3
c8bc774 
Signed-off-by: A.Arnold <anarnold@redhat.com>
@anarnold97 anarnold97 force-pushed the oadp-4884-attributes-update-OADP-1.4.3 branch from 0fa3403 to c8bc774 Compare February 8, 2025 02:45
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 8, 2025

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@amastbau
Copy link

amastbau commented Feb 9, 2025

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2025
@anarnold97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 9, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 10, 2025
xenolinux
xenolinux reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

Assignees

@amastbau amastbau

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anarnold97 @openshift-ci-robot @ocpdocs-previewbot @amastbau @xenolinux @openshift-merge-robot