Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROX-27310]: New page: Understanding the differences in Node CVEs between the Stackrox Scanner and Scanner V4 #88222

Conversation

vikin91
Copy link

@vikin91 vikin91 commented Feb 7, 2025

For users with clusters:

  • switching from Stackrox Scanner to Scanner V4 and
  • using RHCOS node scanning

there may be a surprise effect that there are roughly ~7 times more vulnerabilities reported for the Nodes in the UI.
The document contributed in this PR should be linked to the respective UI page and should serve as an explanation why the users see so many new CVEs.
The PR that adds a banner linking to the page added in this PR: stackrox/stackrox#14130

Version(s):

  • 4.6 (for customer who decided to try tech-preview of Node scanning with Scanner V4)
  • 4.7 (for all customers who use Scanner V4)

Issue:

Link to docs preview:

QE review: ACS has no QE, approved by SME

  • QE has approved this change.

Additional information:

Copy link

openshift-ci bot commented Feb 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2025
@vikin91 vikin91 changed the title [ROX-27310]: New page: Understanding Node Scanning differences obtained for Scanner v2 and v4 [ROX-27310]: New page: Understanding the differences in Node CVEs between the Stackrox Scanner and Scanner V4 Feb 7, 2025
@vikin91 vikin91 marked this pull request as ready for review February 7, 2025 15:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2025
@vikin91 vikin91 marked this pull request as draft February 7, 2025 15:52
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2025
@vikin91
Copy link
Author

vikin91 commented Feb 7, 2025

/test validate-portal
/test validate-asciidoc

@vikin91
Copy link
Author

vikin91 commented Feb 7, 2025

/test validate-portal
/test validate-asciidoc

@vikin91 vikin91 marked this pull request as ready for review February 7, 2025 17:54
@vikin91
Copy link
Author

vikin91 commented Feb 7, 2025

/test validate-portal
/test validate-asciidoc

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2025
@vikin91 vikin91 force-pushed the piotr/ROX-27310-scanning-differences-v2-v4 branch 2 times, most recently from 239dcb7 to 2b0bf25 Compare February 10, 2025 16:27
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Added some suggestions and a few things we have to follow for IBM and Red Hat Style. I think this will really help with the questions that Support tends to get after users switch to Scanner V4.

@kcarmichael08 kcarmichael08 added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.6 rhacs-docs-4.7 peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 10, 2025
@kcarmichael08 kcarmichael08 added this to the Continuous Release milestone Feb 10, 2025
@vikin91 vikin91 force-pushed the piotr/ROX-27310-scanning-differences-v2-v4 branch from 2b0bf25 to 7a90c43 Compare February 10, 2025 22:52
@vikin91
Copy link
Author

vikin91 commented Feb 10, 2025

Many thanks @kcarmichael08 for the swift review! I implemented all the suggestions.
In the next 10 hrs (its midnight here), I will double-check the preview and resolve the conversations in the PR.

Copy link

openshift-ci bot commented Feb 10, 2025

@vikin91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vikin91
Copy link
Author

vikin91 commented Feb 11, 2025

I went again over the text and it looks good, thus resolving all the conversations.
Would be great to merge it soon. Thank you!

@kcarmichael08 kcarmichael08 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 11, 2025
[id="understanding-node-cves-scanner-v4_{context}"]
= Understanding differences in scanning results between the Stackrox Scanner and Scanner V4

== Summary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I missed this before - we aren't supposed to use headings like "Overview" or "Summary". I think we can actually just remove this because what follows is the introductory text - see the mod docs guidance (but to summarize - we don't need a heading here).

Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I noticed one thing when looking at the right TOC - the "summary" heading - can we remove this? Then I can merge - thank you!

@lvalerom
Copy link

@kcarmichael08 unfortunately @vikin91 is on PTO and I cannot change things in his branch. Would it be ok for me to open a new PR from my fork?

@vikin91
Copy link
Author

vikin91 commented Feb 12, 2025

@lvalerom I added you as a contributor to my fork

@kcarmichael08
Copy link
Contributor

Replaced by #88477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.6 rhacs-docs-4.7 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants