-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROX-27310]: New page: Understanding the differences in Node CVEs between the Stackrox Scanner and Scanner V4 #88222
Conversation
Skipping CI for Draft Pull Request. |
/test validate-portal |
🤖 Mon Feb 10 23:00:49 - Prow CI generated the docs preview: https://88222--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/common-vuln-management-tasks.html |
/test validate-portal |
/test validate-portal |
239dcb7
to
2b0bf25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Added some suggestions and a few things we have to follow for IBM and Red Hat Style. I think this will really help with the questions that Support tends to get after users switch to Scanner V4.
2b0bf25
to
7a90c43
Compare
Many thanks @kcarmichael08 for the swift review! I implemented all the suggestions. |
@vikin91: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I went again over the text and it looks good, thus resolving all the conversations. |
[id="understanding-node-cves-scanner-v4_{context}"] | ||
= Understanding differences in scanning results between the Stackrox Scanner and Scanner V4 | ||
|
||
== Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I missed this before - we aren't supposed to use headings like "Overview" or "Summary". I think we can actually just remove this because what follows is the introductory text - see the mod docs guidance (but to summarize - we don't need a heading here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I noticed one thing when looking at the right TOC - the "summary" heading - can we remove this? Then I can merge - thank you!
@kcarmichael08 unfortunately @vikin91 is on PTO and I cannot change things in his branch. Would it be ok for me to open a new PR from my fork? |
@lvalerom I added you as a contributor to my fork |
Replaced by #88477 |
For users with clusters:
there may be a surprise effect that there are roughly ~7 times more vulnerabilities reported for the Nodes in the UI.
The document contributed in this PR should be linked to the respective UI page and should serve as an explanation why the users see so many new CVEs.
The PR that adds a banner linking to the page added in this PR: stackrox/stackrox#14130
Version(s):
Issue:
Link to docs preview:
QE review: ACS has no QE, approved by SME
Additional information: