Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-42747: Added a note about OCP 4.16 #88204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhradilek
Copy link
Contributor

@jhradilek jhradilek commented Feb 6, 2025

Version(s): 4.18+

Issue: CNV-42747

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is an edited version of @orenc1's original content from #86933 with added information from our follow-up conversation.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2025

@jhradilek: This pull request references CNV-42747 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.18+

Issue: CNV-42747

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is an edited version of @orenc1's original content from #86933 with added information from our follow-up conversation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 6, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2025

@jhradilek: This pull request references CNV-42747 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.18+

Issue: CNV-42747

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is an edited version of @orenc1's original content from #86933 with added information from our follow-up conversation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhradilek
Copy link
Contributor Author

Hi @orenc1, could you please review the proposed re-edit of your original admonition and let me know if I got anything wrong? I made three significant changes:

  • I changed the severity of the admonition from Note to Important.
  • After thinking about it some more, I moved the admonition all the way to the top above the steps to ensure that people cannot miss it and proceed with the upgrade beyond 4.16 without noticing it.
  • I reworded the text a little and added your command to list outdated VMIs and recommendation to migrate these manually.

If you are happy with where this is heading, please feel free to close your PR.

@jhradilek
Copy link
Contributor Author

/label cnv

@openshift-ci openshift-ci bot added the CNV Label for all CNV PRs label Feb 6, 2025
@jhradilek jhradilek force-pushed the CNV-42747-workload-updates branch from 0929ed5 to e0ef055 Compare February 7, 2025 14:50
This is an edited version of Oren's original content from PR openshift#86933 and
extended by me based on information kindly provided by him.
@jhradilek jhradilek force-pushed the CNV-42747-workload-updates branch from e0ef055 to b5ca268 Compare February 7, 2025 15:17
@@ -12,6 +12,8 @@ After you update from the source EUS version to the next odd-numbered minor vers

When the {product-title} update succeeds, the corresponding update for {VirtProductName} becomes available. You can now update {VirtProductName} to the target EUS version.

For more information about EUS versions, see the link:https://access.redhat.com/support/policy/updates/openshift[Red Hat OpenShift Container Platform Life Cycle Policy].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{product-title}' rather than the plain text product term 'OpenShift Container Platform', unless your use case is an exception.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do believe my use case should be an exception as I am referring to a page with a static title that is not dependent on the build parameters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctomasko FYI, I was looking for a natural place to link to the life cycle policy as you suggested.

Copy link

openshift-ci bot commented Feb 7, 2025

@jhradilek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025

@jhradilek: This pull request references CNV-42747 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.18+

Issue: CNV-42747

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is an edited version of @orenc1's original content from #86933 with added information from our follow-up conversation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants