-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-42747: Added a note about OCP 4.16 #88204
base: main
Are you sure you want to change the base?
Conversation
@jhradilek: This pull request references CNV-42747 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri Feb 07 15:26:38 - Prow CI generated the docs preview: https://88204--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/updating/upgrading-virt.html |
@jhradilek: This pull request references CNV-42747 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hi @orenc1, could you please review the proposed re-edit of your original admonition and let me know if I got anything wrong? I made three significant changes:
If you are happy with where this is heading, please feel free to close your PR. |
/label cnv |
0929ed5
to
e0ef055
Compare
This is an edited version of Oren's original content from PR openshift#86933 and extended by me based on information kindly provided by him.
e0ef055
to
b5ca268
Compare
@@ -12,6 +12,8 @@ After you update from the source EUS version to the next odd-numbered minor vers | |||
|
|||
When the {product-title} update succeeds, the corresponding update for {VirtProductName} becomes available. You can now update {VirtProductName} to the target EUS version. | |||
|
|||
For more information about EUS versions, see the link:https://access.redhat.com/support/policy/updates/openshift[Red Hat OpenShift Container Platform Life Cycle Policy]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{product-title}' rather than the plain text product term 'OpenShift Container Platform', unless your use case is an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do believe my use case should be an exception as I am referring to a page with a static title that is not dependent on the build parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctomasko FYI, I was looking for a natural place to link to the life cycle policy as you suggested.
@jhradilek: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@jhradilek: This pull request references CNV-42747 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Version(s): 4.18+
Issue: CNV-42747
Link to docs preview:
QE review:
Additional information:
This is an edited version of @orenc1's original content from #86933 with added information from our follow-up conversation.