Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARO-11084: Helm chart generator #4872

Merged
merged 2 commits into from
Oct 28, 2024
Merged

ARO-11084: Helm chart generator #4872

merged 2 commits into from
Oct 28, 2024

Conversation

geoberle
Copy link
Contributor

@geoberle geoberle commented Oct 9, 2024 •
edited
Loading

What this PR does / why we need it:

Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command.

the PR also introduces a way to template the registry overrides option of the operator

required by Azure/ARO-HCP#698

Which issue(s) this PR fixes:

Fixes #ARO-11084

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/cli Indicates the PR includes changes for CLI labels Oct 9, 2024
@geoberle geoberle mentioned this pull request Oct 9, 2024
Merged
@geoberle geoberle changed the title Helm Helm chart generator Oct 9, 2024
@geoberle geoberle marked this pull request as ready for review October 10, 2024 08:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2024
@geoberle geoberle force-pushed the helm branch 2 times, most recently from 2ef9b18 to 51102a8 Compare October 10, 2024 09:30
@geoberle
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2024
@bryan-cox
Copy link
Member

bryan-cox commented Oct 14, 2024 •
edited by openshift-ci bot
Loading

/retitle ARO-11084: Helm chart generator

@openshift-ci openshift-ci bot changed the title Helm chart generator ARO-11084: Helm chart generator Oct 14, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024 •
edited by openshift-ci bot
Loading

@geoberle: This pull request references ARO-11084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command.

the PR also introduces a way to template the registry overrides option of the operator

required by Azure/ARO-HCP#698

Which issue(s) this PR fixes:

Fixes #ARO-11084

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, geoberle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@geoberle
Copy link
Contributor Author

/retest

csrwng
csrwng reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@csrwng csrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, otherwise, lgtm

@netlify Netlify
Copy link

netlify bot commented Oct 18, 2024 •
edited
Loading

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 24d670e
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/671b8da48cd82e0009cfb60c
😎 Deploy Preview https://deploy-preview-4872--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@csrwng
Copy link
Contributor

csrwng commented Oct 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2082bf0 and 2 for PR HEAD 2d40c86 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 37288c9 and 2 for PR HEAD 2d40c86 in total

@csrwng
Copy link
Contributor

csrwng commented Oct 18, 2024

/hold
@geoberle looks like you need to fix the unit tests

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@bryan-cox
Copy link
Member

/test e2e-aks

@geoberle geoberle force-pushed the helm branch 2 times, most recently from c4588e5 to 24d670e Compare October 25, 2024 12:22
@geoberle
introduce helm chart generator cmd
97e99b6 
based on the code from the existing `install render --template`
command, a helm chart generator has been introduced in this commit.

common template rendering functionality has been extracted into `render.go`
and is used by both openshift template and helm chart generators.

Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
@geoberle
allow templating for registry overrides and azure KV client id
a45df44 
Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
@enxebre
Copy link
Member

enxebre commented Oct 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@enxebre
Copy link
Member

enxebre commented Oct 28, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2024
@enxebre enxebre mentioned this pull request Oct 28, 2024
Merged
4 tasks
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 28, 2024

@geoberle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a95fc46 into openshift:main Oct 28, 2024
14 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.18.0-202410281841.p0.ga95fc46.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@csrwng csrwng csrwng left review comments

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@enxebre enxebre

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@geoberle @bryan-cox @openshift-ci-robot @csrwng @enxebre @openshift-bot @openshift-merge-robot