cleanup

Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
openshift · Oct 10, 2024 · 51102a8 · 51102a8
1 parent b49b387
commit 51102a8
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 11 deletions.
diff --git a/cmd/install/install.go b/cmd/install/install.go
@@ -161,7 +161,6 @@ func (o *Options) Validate() error {
 	if len(o.ManagedService) > 0 && o.ManagedService != hyperv1.AroHCP {
 		errs = append(errs, fmt.Errorf("not a valid managed service type: %s", o.ManagedService))
 	}
-	// todo: validate opts.RegistryOverrides
 	return errors.NewAggregate(errs)
 }
 

diff --git a/cmd/install/install_helm_test.go b/cmd/install/install_helm_test.go
@@ -66,5 +66,4 @@ func TestHelmCommand(t *testing.T) {
 		t.Fatalf("values.yaml file %s does not exist", valuesPath)
 	}
 
-
 }
diff --git a/cmd/install/install_render.go b/cmd/install/install_render.go
@@ -283,12 +283,3 @@ func (p *ObjectPatch) CanBeAppliedTo(obj crclient.Object) bool {
 	}
 	return true
 }
-
-func getByKindAndName(objects []crclient.Object, kind, name string) (crclient.Object, error) {
-	for _, obj := range objects {
-		if obj.GetObjectKind().GroupVersionKind().Kind == kind && obj.GetName() == name {
-			return obj, nil
-		}
-	}
-	return nil, fmt.Errorf("object not found: kind=%s, name=%s", kind, name)
-}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -66,5 +66,4 @@ func TestHelmCommand(t *testing.T) {
		t.Fatalf("values.yaml file %s does not exist", valuesPath)
		}


		}