[release-4.18] OCPBUGS-48377: Add IdleConnectionTerminationPolicy field to IngressControllerSpec

[alebedev87]

Add an IdleConnectionTerminationPolicy field to control whether HAProxy keeps idle frontend connections open during a soft stop (router reload). Allow users to prevent errors in clients or load balancers that do not properly handle connection resets.

This PR is a manual cherry-pick of #2102 with a key difference in the default value. For OCP versions <= 4.18, the default is Deferred, aligning with older releases where HAProxy’s idle-close-on-response option was added unconditionally.

[openshift-ci]

Hello @alebedev87! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-48377, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-43745 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-43745 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
• bug has dependents

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add an IdleConnectionTerminationPolicy field to control whether HAProxy keeps idle frontend connections open during a soft stop (router reload). Allow users to prevent errors in clients or load balancers that do not properly handle connection resets.

This commit is based on #2102 with a key in the default value. For OCP versions <= 4.18, the default is Deferred, aligning with older releases where HAProxy’s idle-close-on-response option was added unconditionally.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gangwgr]

/label cherry-pick-approved

[JoelSpeed]

/label backport-risk-assessed

[openshift-ci-robot]

@alebedev87: Jira Issue OCPBUGS-48377: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/router#647 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-48377 has not been moved to the MODIFIED state.

In response to this:

Add an IdleConnectionTerminationPolicy field to control whether HAProxy keeps idle frontend connections open during a soft stop (router reload). Allow users to prevent errors in clients or load balancers that do not properly handle connection resets.

This PR is a manual cherry-pick of #2102 with a key difference in the default value. For OCP versions <= 4.18, the default is Deferred, aligning with older releases where HAProxy’s idle-close-on-response option was added unconditionally.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202501291931.p0.gd15841b.assembly.stream.el9.
All builds following this will include this PR.

[alebedev87]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@alebedev87: #2178 failed to apply on top of branch "release-4.17":

Applying: OCPBUGS-48377: Add IdleCloseOnResponse field to IngressControllerSpec
Using index info to reconstruct a base tree...
M	openapi/generated_openapi/zz_generated.openapi.go
M	openapi/openapi.json
M	operator/v1/tests/ingresscontrollers.operator.openshift.io/AAA_ungated.yaml
A	operator/v1/tests/ingresscontrollers.operator.openshift.io/IngressControllerLBOpenStack.yaml
M	operator/v1/tests/ingresscontrollers.operator.openshift.io/IngressControllerLBSubnetsAWS.yaml
M	operator/v1/tests/ingresscontrollers.operator.openshift.io/SetEIPForNLBIngressController.yaml
M	operator/v1/types_ingress.go
M	operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers.crd.yaml
M	operator/v1/zz_generated.featuregated-crd-manifests/ingresscontrollers.operator.openshift.io/AAA_ungated.yaml
M	operator/v1/zz_generated.featuregated-crd-manifests/ingresscontrollers.operator.openshift.io/IngressControllerLBSubnetsAWS.yaml
M	operator/v1/zz_generated.featuregated-crd-manifests/ingresscontrollers.operator.openshift.io/SetEIPForNLBIngressController.yaml
M	operator/v1/zz_generated.swagger_doc_generated.go
Falling back to patching base and 3-way merge...
Auto-merging operator/v1/zz_generated.swagger_doc_generated.go
Auto-merging operator/v1/zz_generated.featuregated-crd-manifests/ingresscontrollers.operator.openshift.io/SetEIPForNLBIngressController.yaml
Auto-merging operator/v1/zz_generated.featuregated-crd-manifests/ingresscontrollers.operator.openshift.io/IngressControllerLBSubnetsAWS.yaml
Auto-merging operator/v1/zz_generated.featuregated-crd-manifests/ingresscontrollers.operator.openshift.io/AAA_ungated.yaml
Auto-merging operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers.crd.yaml
Auto-merging operator/v1/types_ingress.go
Auto-merging operator/v1/tests/ingresscontrollers.operator.openshift.io/SetEIPForNLBIngressController.yaml
Auto-merging operator/v1/tests/ingresscontrollers.operator.openshift.io/IngressControllerLBSubnetsAWS.yaml
CONFLICT (modify/delete): operator/v1/tests/ingresscontrollers.operator.openshift.io/IngressControllerLBOpenStack.yaml deleted in HEAD and modified in OCPBUGS-48377: Add IdleCloseOnResponse field to IngressControllerSpec. Version OCPBUGS-48377: Add IdleCloseOnResponse field to IngressControllerSpec of operator/v1/tests/ingresscontrollers.operator.openshift.io/IngressControllerLBOpenStack.yaml left in tree.
Auto-merging operator/v1/tests/ingresscontrollers.operator.openshift.io/AAA_ungated.yaml
Auto-merging openapi/openapi.json
Auto-merging openapi/generated_openapi/zz_generated.openapi.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-48377: Add IdleCloseOnResponse field to IngressControllerSpec

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.