OCM-6311 | feat: Migrate common code to ocm-common repo #92
ciaranRochecheck-pull-request.yml
on: pull_request
Lint
1m 20s
Matrix: Test
Annotations
20 errors and 2 warnings
|
Test (ubuntu-latest):
pkg/aws/aws_client/network_interface.go#L37
github.com/openshift-online/ocm-common/pkg/log.LogError format %s has arg networkinterface.NetworkInterfaceId of wrong type *string
|
|
Test (ubuntu-latest):
pkg/aws/aws_client/network_interface.go#L51
github.com/openshift-online/ocm-common/pkg/log.LogInfo format %s has arg networkinterface.NetworkInterfaceId of wrong type *string
|
|
Test (ubuntu-latest):
pkg/aws/aws_client/route53.go#L26
github.com/openshift-online/ocm-common/pkg/log.LogError call needs 2 args but has 3 args
|
|
Test (ubuntu-latest):
pkg/aws/aws_client/route53.go#L28
github.com/openshift-online/ocm-common/pkg/log.LogError call needs 2 args but has 3 args
|
|
Test (ubuntu-latest):
pkg/test/vpc_client/security_group.go#L53
github.com/openshift-online/ocm-common/pkg/log.LogError format %s has arg port of wrong type int32
|
|
Test (ubuntu-latest)
Process completed with exit code 2.
|
|
Test (windows-latest)
The job was canceled because "ubuntu-latest" failed.
|
|
Test (windows-latest)
The operation was canceled.
|
|
Lint:
pkg/aws/aws_client/eip.go#L60
Error return value of `client.ReleaseAddress` is not checked (errcheck)
|
|
Lint:
pkg/aws/aws_client/vpc.go#L62
Error return value of `client.TagResource` is not checked (errcheck)
|
|
Lint:
pkg/test/vpc_client/bastion.go#L47
Error return value of `vpc.AWSClient.TagResource` is not checked (errcheck)
|
|
Lint:
pkg/test/vpc_client/internet_gateway.go#L17
Error return value of `vpc.AWSClient.AttachInternetGateway` is not checked (errcheck)
|
|
Lint:
pkg/test/vpc_client/proxy.go#L59
Error return value of `vpc.AWSClient.TagResource` is not checked (errcheck)
|
|
Lint:
pkg/test/vpc_client/vpc.go#L255
Error return value of `cidrPool.Reserve` is not checked (errcheck)
|
|
Lint:
pkg/test/vpc_client/helper.go#L38
func `isPrivate` is unused (unused)
|
|
Lint:
pkg/aws/aws_client/env.go#L12
S1008: should use 'return os.Getenv("AWS_SHARED_CREDENTIALS_FILE") != ""' instead of 'if os.Getenv("AWS_SHARED_CREDENTIALS_FILE") != "" { return true }; return false' (gosimple)
|
|
Lint:
pkg/aws/aws_client/network_acl.go#L31
S1011: should replace loop with `customizedAcls = append(customizedAcls, output.NetworkAcls...)` (gosimple)
|
|
Lint:
pkg/test/vpc_client/cidr.go#L28
S1006: should use for {} instead of for true {} (gosimple)
|
|
Test (macos-latest)
The job was canceled because "ubuntu-latest" failed.
|
|
Test (macos-latest)
The operation was canceled.
|
|
Test (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, actions/cache@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|