Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aro_hcp v1alpha1 Root resource #1006

Merged

Conversation

nimrodshn
Copy link
Contributor

Create a new root resource for the /aro_hcp service and add a locator with reference to the /clusters_mgmt/v1/clusters locator.

This PR is depending on openshift-online/ocm-api-metamodel#210.

@nimrodshn nimrodshn force-pushed the add_aro_hcp_v1_alpha1_service branch from 0197d86 to 57ed1af Compare December 2, 2024 20:27
@nimrodshn nimrodshn force-pushed the add_aro_hcp_v1_alpha1_service branch 5 times, most recently from afc456d to 4aee959 Compare December 8, 2024 13:50
@nimrodshn nimrodshn force-pushed the add_aro_hcp_v1_alpha1_service branch from 4aee959 to 79f4f16 Compare December 11, 2024 12:50
@nimrodshn
Copy link
Contributor Author

Note to self - Need to bump meta-model version

@tzvatot
Copy link
Contributor

tzvatot commented Dec 12, 2024

Why is the path v1_alpha1 and not v1alpha1?

@nimrodshn nimrodshn force-pushed the add_aro_hcp_v1_alpha1_service branch from 79f4f16 to 9984093 Compare December 12, 2024 19:29
@nimrodshn
Copy link
Contributor Author

nimrodshn commented Dec 12, 2024

Why is the path v1_alpha1 and not v1alpha1?

@tzvatot Done. thank you!

@nimrodshn nimrodshn force-pushed the add_aro_hcp_v1_alpha1_service branch from 9984093 to e804101 Compare December 12, 2024 19:32
@ahitacat
Copy link
Contributor

To compile this new model we require the metamodel v0.062 #1010

Copy link
Collaborator

@zgalor zgalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zgalor zgalor merged commit 715458b into openshift-online:main Dec 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants