[release-4.16] CNF-15765: CI fixes #2231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for env like hypershift we don't have MCO so we need to use the sriov-config-daemon that is running on the cluster Signed-off-by: Sebastian Sch <sebassch@gmail.com>
In the context of the test case
```
[It] [sriov] NUMA node alignment Utilize all available VFs then create a pod with guaranteed CPU and excludeTopology set to True
```
a flake might happen when restoring the original MCP takes more than 10 minutes.
This behavior can be spotted by looking the sample failure [1]:
```
Enter [DeferCleanup (All) [sriov] NUMA node alignment @ 11/16/24 10:25:34.562
I1116 10:25:34.715725 35799 machineconfigpool.go:311] Moved back node role from [test-sriov-numa] to [worker-cnf] on cnfdu1
I1116 10:25:40.875535 35799 machineconfigpool.go:143] MCP worker-cnf is updating
I1116 10:25:40.928764 35799 machineconfigpool.go:28] Waiting for MCP master: Updating == False
I1116 10:25:40.972478 35799 machineconfigpool.go:36] Condition met for MCP master: Updating == False
I1116 10:25:40.972511 35799 machineconfigpool.go:28] Waiting for MCP test-sriov-numa: Updating == False
I1116 10:25:41.009940 35799 machineconfigpool.go:36] Condition met for MCP test-sriov-numa: Updating == False
I1116 10:25:41.009966 35799 machineconfigpool.go:28] Waiting for MCP worker: Updating == False
I1116 10:25:41.084047 35799 machineconfigpool.go:36] Condition met for MCP worker: Updating == False
I1116 10:25:41.084073 35799 machineconfigpool.go:28] Waiting for MCP worker-cnf: Updating == False
[FAILED] in [DeferCleanup (All)] - /tmp/cnf-52ioJ/cnf-features-deploy/cnf-tests/testsuites/e2esuite/dpdk/numa_node_sriov.go:124 @ 11/16/24 10:35:41.213
```
the failed at `10:35:41.213`, while the MCP would have been ready at `10:35:45`. From node's journal:
```
Nov 16 10:25:40 cnfdu1 root[20293]: machine-config-daemon[5990]: Starting update from rendered-test-sriov-numa-a8151b5c8ef3843ebccffeac4ea1f436 to rendered-worker-cnf-0b30d70ee563f0c62337acea72ef80e1: &{osUpdate:false kargs:true fips:false passwd:false files:true units:true kernelType:true extensions:false}
...
Nov 16 10:28:33 cnfdu1 root[41926]: machine-config-daemon[5990]: Rebooting node
Nov 16 10:28:33 cnfdu1 root[41927]: machine-config-daemon[5990]: initiating reboot: Node will reboot into config rendered-worker-cnf-0b30d70ee563f0c62337acea72ef80e1
Nov 16 10:28:33 cnfdu1 systemd[1]: Started machine-config-daemon: Node will reboot into config rendered-worker-cnf-0b30d70ee563f0c62337acea72ef80e1.
Nov 16 10:28:33 cnfdu1 root[41930]: machine-config-daemon[5990]: reboot successful
Nov 16 10:28:33 cnfdu1 systemd-logind[2786]: The system will reboot now!
Nov 16 10:28:33 cnfdu1 systemd-logind[2786]: System is rebooting.
Nov 16 10:28:33 cnfdu1 systemd[1]: machine-config-daemon-reboot.service: Deactivated successfully.
Nov 16 10:28:33 cnfdu1 systemd[1]: Stopped machine-config-daemon: Node will reboot into config rendered-worker-cnf-0b30d70ee563f0c62337acea72ef80e1.
...
Nov 16 10:30:38 cnfdu1 systemd[1]: Stopping Flush Journal to Persistent Storage...
-- Boot eb8af1b825ef44239a040ec07d5be804 --
Nov 16 10:33:35 localhost kernel: microcode: microcode updated early to revision 0xd0003d1, date = 2023-09-14
Nov 16 10:33:35 localhost kernel: Linux version 5.14.0-284.92.1.rt14.377.el9_2.x86_64 (mockbuild@x86-64-03.build.eng.rdu2.redhat.com) (gcc (GCC) 11.3.1 20221121 (Red Hat 11.3.1-4), GNU ld version 2.35.2-37.el9) openshift-kni#1 SMP PREEMPT_RT Fri Nov 1 12:51:15 EDT 2024
Nov 16 10:35:32 cnfdu1 root[18202]: machine-config-daemon[17025]: Starting to manage node: cnfdu1
...
Nov 16 10:35:35 cnfdu1 root[19315]: machine-config-daemon[17025]: Disk currentConfig "rendered-worker-cnf-0b30d70ee563f0c62337acea72ef80e1" overrides node's currentConfig annotation "rendered-test-sriov-numa-a8151b5c8ef3843ebccffeac4ea1f436"
...
Nov 16 10:35:45 cnfdu1 root[23677]: machine-config-daemon[17025]: Update completed for config rendered-worker-cnf-0b30d70ee563f0c62337acea72ef80e1 and node has been successfully uncordoned
```
[1] https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.15-e2e-telco5g-cnftests/1857695365185146880
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Since the tests are re-attempted on failure, we should cleanup the NADs each time to not get an "Already exists" error on the retries. Also, added a missing Expect(err). Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@zeeke: This pull request references CNF-15765 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.z" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/hold wait for 4.17 fixes |
openshift-ci
bot
added
the
do-not-merge/hold
Container image size of `quay.io/openshift-kni/cnf-tests:4.18` is 1.85GB: ``` $ docker images quay.io/openshift-kni/cnf-tests:4.18 REPOSITORY TAG IMAGE ID CREATED SIZE quay.io/openshift-kni/cnf-tests 4.18 a58152e3611a 22 hours ago 1.85GB ``` This cause test flakiness, as pulling the image might exceed timeouts. [1] Most of the problem is in the dnf cache: ``` $ docker run quay.io/openshift-kni/cnf-tests:4.18 du -sh /var/cache/dnf 1.2G /var/cache/dnf ``` Add `yum clean all` command after installing dependencies in the final image With these changes, the image size is reduced to `665MB`: ``` $ docker images local-cnf-tests REPOSITORY TAG IMAGE ID CREATED SIZE local-cnf-tests latest 681d224cbd65 44 seconds ago 665MB ``` [1] https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift-kni_cnf-features-deploy/1990/pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ci-tests/1843231458743816192 Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
|
/retest |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
|
@zeeke: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of:
WaitForAllMCPStabletimeout #2110