Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnf-tests: update submodules #2228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

shajmakh
Copy link
Member

@shajmakh shajmakh commented Feb 7, 2025

run: git submodule update --remote.

run: `git submodule update --remote`.

Signed-off-by: Shereen Haj <shajmakh@redhat.com>
@openshift-ci openshift-ci bot requested review from imiller0 and sabbir-47 February 7, 2025 08:00
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shajmakh
Once this PR has been reviewed and has the lgtm label, please assign lack for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shajmakh
Copy link
Member Author

shajmakh commented Feb 7, 2025

/cc @SchSeba @zeeke
please let me know if you prefer not to merge metallb and sriov bump

@openshift-ci openshift-ci bot requested review from SchSeba and zeeke February 7, 2025 11:38
@MarSik
Copy link
Member

MarSik commented Feb 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
@zeeke
Copy link
Member

zeeke commented Feb 11, 2025

submodules in this repository are locally updated during every test run. So, updating them only affects developers that checkout the repository for the first time.
Though, I don't have anything against keeping them updated

/lgtm

test failure is not related to this PR

[It] metallb MetalLB deploy should work when deployed with BGP type FRR-K8s Mode

/override ci/prow/e2e-aws-ci-tests

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

@zeeke: Overrode contexts on behalf of zeeke: ci/prow/e2e-aws-ci-tests

In response to this:

submodules in this repository are locally updated during every test run. So, updating them only affects developers that checkout the repository for the first time.
Though, I don't have anything against keeping them updated

/lgtm

test failure is not related to this PR

[It] metallb MetalLB deploy should work when deployed with BGP type FRR-K8s Mode

/override ci/prow/e2e-aws-ci-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shajmakh
Copy link
Member Author

submodules in this repository are locally updated during every test run. So, updating them only affects developers that checkout the repository for the first time. Though, I don't have anything against keeping them updated

/lgtm

test failure is not related to this PR

[It] metallb MetalLB deploy should work when deployed with BGP type FRR-K8s Mode

/override ci/prow/e2e-aws-ci-tests

Thank you for the review and the info. The cnf-tests build process uses the submodule to make the latency tests binary from NTO end. although the updates there not anticipated to break anything, I think it's fine too use most updated version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants