-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cnf-tests: update submodules #2228
base: master
Are you sure you want to change the base?
Conversation
run: `git submodule update --remote`. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
submodules in this repository are locally updated during every test run. So, updating them only affects developers that checkout the repository for the first time. /lgtm test failure is not related to this PR
/override ci/prow/e2e-aws-ci-tests |
@zeeke: Overrode contexts on behalf of zeeke: ci/prow/e2e-aws-ci-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thank you for the review and the info. The cnf-tests build process uses the submodule to make the latency tests binary from NTO end. although the updates there not anticipated to break anything, I think it's fine too use most updated version. |
run:
git submodule update --remote
.