Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-49909: ztp: Set up ptpClockThreshold in source-crs and reference templates #2221

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-49909: ztp: Set up ptpClockThreshold in source-crs and reference templates #2221

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2218

/assign lack

@lack
ztp: Set up ptpClockThreshold in source-crs and reference templates
4dc2a0a 
This change allows ptpClockThreshold to be set in all PtpConfig
scenarios, and also provides default values for the *ForEvent examples
in source-crs.

Signed-off-by: Jim Ramsay <jramsay@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 5, 2025
Merged
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: Jira Issue OCPBUGS-49900 has been cloned as Jira Issue OCPBUGS-49909. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-49909: ztp: Set up ptpClockThreshold in source-crs and reference templates

In response to this:

This is an automated cherry-pick of #2218

/assign lack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from imiller0 and vitus133 February 5, 2025 22:09
@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-49900: ztp: Set up ptpClockThreshold in source-crs and reference templates [release-4.17] OCPBUGS-49909: ztp: Set up ptpClockThreshold in source-crs and reference templates Feb 5, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 5, 2025
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-49909, which is invalid:

  • expected dependent Jira Issue OCPBUGS-49900 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2218

/assign lack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lack
Copy link
Member

lack commented Feb 5, 2025

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiller0 imiller0 Awaiting requested review from imiller0

@vitus133 vitus133 Awaiting requested review from vitus133

Assignees

@lack lack

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @lack