Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/cloudevents/conformance to v0.4.1 #1144

Open
wants to merge 1 commit into
base: release-v1.17
Choose a base branch
from

Conversation

red-hat-konflux-kflux-prd-rh02[bot]

This PR contains the following updates:

Package Type Update Change
github.com/cloudevents/conformance require minor v0.2.0 -> v0.4.1

Release Notes

cloudevents/conformance (github.com/cloudevents/conformance)

v0.4.1: Improved diff

Compare Source

Found a bug where I expected to be able to say --match foo,bar but cobra does not split on comma, adding the ability to split on comma for the match flag.

Improved matching and searching while diffing a to b events.

v0.4.0: Adding Diff command

Compare Source

diff compares two yaml event files.

cloudevents diff ./want.yaml ./got.yaml

want.yaml could have fewer fields specified to allow for fuzzy matching.

Example, if you only wanted to compare on type and ignore additional fields:

$ cat ./want.yaml
ContextAttributes:
  type: com.example.someevent
$ cat ./got.yaml
Mode: structured
ContextAttributes:
  specversion: 1.0
  type: com.example.someevent
  time: 2018-04-05T03:56:24Z
  id: 4321-4321-4321-a
  source: /mycontext/subcontext
  Extensions:
    comexampleextension1 : "value"
    comexampleextension2 : |
      {"othervalue": 5}
TransportExtensions:
  user-agent: "foo"
Data: |
  {"world":"hello"}

$ cloudevents diff ./want.yaml ./got.yaml --match type --ignore-additions

This validates that at least one event of type com.example.someevent is present in the got.yaml file.

v0.3.0: Adding history to listen command to cli.

Compare Source

New feature: return back the events that listen has collected via a GET on /history .

Start the listener:

$ cloudevents listen
listening on :8080

Send a cloudevent:

$ cloudevents send http://localhost:8080/ --id abc-123 --source cloudevents.conformance.tool --type foo.bar

See it is collected by the listener:

$  go run ./cmd/cloudevents listen
listening on :8080
Mode: binary
ContextAttributes:
  specversion: "1.0"
  type: foo.bar
  id: abc-123
  source: cloudevents.conformance.tool
TransportExtensions:
  User-Agent: Go-http-client/1.1
Data: ""
---

Collect history:

$ curl http://localhost:8080/history
Mode: binary
ContextAttributes:
  specversion: "1.0"
  type: foo.bar
  id: abc-123
  source: cloudevents.conformance.tool
TransportExtensions:
  User-Agent: Go-http-client/1.1
Data: ""

Configuration

📅 Schedule: Branch creation - "after 5am on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

This PR has been generated by MintMaker (powered by Renovate Bot).

Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
@openshift-ci openshift-ci bot requested review from creydr and lberk February 23, 2025 20:17
Copy link

openshift-ci bot commented Feb 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux-kflux-prd-rh02[bot]
Once this PR has been reviewed and has the lgtm label, please assign lberk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Feb 23, 2025

Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR.

I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants