Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] Backport of knative#1973 #504

Conversation

cardil
Copy link
Member

@cardil cardil commented Nov 5, 2024

release-1.16

Backport of knative#1973

Required for openshift-knative/kn-plugin-event#556

@cardil
Copy link
Member Author

cardil commented Nov 6, 2024

416-test-e2e-aws-416 — Context retired without replacement.

And there's no 4.17 flavor, despite it is there: https://github.com/openshift/release/blob/master/ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.16__417.yaml. Looks to me like a ci-operator hiccup.

@cardil
Copy link
Member Author

cardil commented Nov 7, 2024

/retest

(Trying to revive Prow)

Copy link

openshift-ci bot commented Dec 3, 2024

@cardil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-images 89d31d6 link true /test 416-images
ci/prow/416-test-e2e-aws-416 89d31d6 link true /test 416-test-e2e-aws-416
ci/prow/417-test-e2e-aws-417 c7a7d75 link true /test 417-test-e2e-aws-417

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dsimansk
Copy link

dsimansk commented Dec 6, 2024

/retest

@dsimansk
Copy link

dsimansk commented Dec 6, 2024

/approve
/lgtm

Copy link

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 71d4c28 into openshift-knative:release-v1.16 Dec 6, 2024
4 checks passed
@cardil cardil deleted the backport/1.16/pr-1973 branch December 6, 2024 18:29
cardil added a commit to cardil/kn-plugin-event that referenced this pull request Dec 6, 2024
openshift-merge-bot bot pushed a commit to openshift-knative/kn-plugin-event that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants