Skip to content

Commit 110ed46

Browse files
committed
Attempt to fix unit conversions
1 parent 8292520 commit 110ed46

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

opensensor/collection_apis.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -274,9 +274,7 @@ def create_model_instance(model: Type[BaseModel], data: dict, target_unit: Optio
274274
continue
275275

276276
# Handle temperature unit conversion if applicable
277-
if field_name == "temp" and target_unit and mongo_field in data:
278-
data[field_name] = convert_temperature(data[mongo_field], target_unit)
279-
elif mongo_field in data:
277+
if mongo_field in data:
280278
data[field_name] = data[mongo_field]
281279
elif field_name in data:
282280
# If the field_name exists in data, use it
@@ -305,7 +303,10 @@ def create_model_instance(model: Type[BaseModel], data: dict, target_unit: Optio
305303
)
306304

307305
logger.debug(f"Creating instance of {model.__name__} with data: {data}")
308-
return model(**data)
306+
result = model(**data)
307+
if isinstance(result, Temperature) and target_unit:
308+
convert_temperature(result, target_unit)
309+
return result
309310

310311

311312
def get_vpd_pipeline(

0 commit comments

Comments
 (0)