Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blake2b hash #5089

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

terryquigleysas
Copy link
Contributor

Description

  • Bug fix
  • Blake2b is deterministic. Passing the parameters incorrectly results in the wrong hash being produced.
  • What is the old behavior before changes and new behavior after changes?
    This may be considered a "Breaking Change" for 3.0.0 as the hashes will now be different - correct, but different from before.

Issues Resolved

Resolves #4274

Testing

Updated existing tests.
Ran Bulk Integration Test action against the branch.
Local testing.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

terryquigleysas and others added 4 commits February 4, 2025 14:30
Signed-off-by: Terry Quigley <terry.quigley@sas.com>
Signed-off-by: Terry Quigley <terry.quigley@sas.com>
Signed-off-by: Terry Quigley <terry.quigley@sas.com>
cwperks
cwperks previously approved these changes Feb 5, 2025
Signed-off-by: Terry Quigley <terry.quigley@sas.com>
@nibix
Copy link
Collaborator

nibix commented Feb 6, 2025

Note: In a mixed cluster state, this will yield inconsistent results: Some nodes will hash value A to hash X, while other nodes will hash value A to hash Y. This will especially affect aggregations. Are we okay with this (genuine question)? In any case, this should be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Blake2b hashing for Masked Fields does not apply salt correctly
3 participants