-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation issues after upgrade to Lucene 10 #5053
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
src/main/java/org/opensearch/security/configuration/DlsFlsFilterLeafReader.java
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks lot @cwperks !
@reta There are failing checks that I'm struggling to resolve. The bwc test: https://github.com/opensearch-project/security/actions/runs/13251050903/job/36989972019?pr=5053 A few FLS tests: https://github.com/opensearch-project/security/actions/runs/13251050903/job/36989977628?pr=5053 Edit: BWC failures are due to running alpha1 security w/o running the respective build of the core |
Yes, @cwperks , just looking into them as well, the first strange thing - usage of
Looking closely |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
Fixed those, but not DLS ones ... |
Signed-off-by: Andriy Redko <drreta@gmail.com>
src/test/java/org/opensearch/security/dlic/dlsfls/FlsExistsFieldsTest.java
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5053 +/- ##
==========================================
- Coverage 71.55% 71.47% -0.09%
==========================================
Files 336 336
Lines 22649 22647 -2
Branches 3603 3603
==========================================
- Hits 16207 16187 -20
- Misses 4643 4660 +17
- Partials 1799 1800 +1
|
Merging this with single approval to unblock the build and other components affected by security |
Description
Adapt to Lucene 10 changes from core. Related PR: opensearch-project/OpenSearch#16366
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.