Add "cluster:monitor/term" to DNFOF tests #4156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
stephen-crawford
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
stephen-crawford
added
backport 2.x
|
It doesn't seem to like the Build failure: https://github.com/opensearch-project/security/actions/runs/8391770861/job/22983145888?pr=4156 Edit: Possibly related: opensearch-project/OpenSearch#12807 |
|
@zelinh Do you think the error seen in the CI here are related to the core changes that went in a little while ago around changes to pluginZip? |
|
Going to block this since I made the change in (#4157) Not sure what these failures are though so leaving it open so @peterzhuamazon or someone can look. |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add "cluster:monitor/term" to DNFOF tests since the failing integration test is caused by this line being missing
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.