-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Resolve logback-classic to 1.2.13 #3824
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #3824 +/- ##
============================================
+ Coverage 64.90% 64.93% +0.02%
- Complexity 3663 3668 +5
============================================
Files 292 292
Lines 20648 20648
Branches 3402 3402
============================================
+ Hits 13402 13408 +6
+ Misses 5563 5561 -2
+ Partials 1683 1679 -4 |
@derek-ho Could you please resolve the conflicts in the build.gradle and create/update flaky test failures from this build? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-3824-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 300314931980c9727e11757c640c4692ae023c03
# Push it to GitHub
git push --set-upstream origin backport/backport-3824-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-3824-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 300314931980c9727e11757c640c4692ae023c03
# Push it to GitHub
git push --set-upstream origin backport/backport-3824-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
Description
Resolve logback-classic to 1.2.13
Backport of: #3823
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.