Add TPC-H PPL query suite #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
YANG-DB
added
Lang:PPL
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
5 tasks
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
dai-chen,
rupal-bq,
mengweieric,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger and
ykmr1224
as code owners
YANG-DB
reviewed
Nov 6, 2024
|
|
||
| All TPC-H PPL Queries located in `integ-test/src/integration/resources/tpch` folder. | ||
|
|
||
| To test all queries, run `org.opensearch.flint.spark.ppl.tpch.TPCHQueryITSuite`. |
There was a problem hiding this comment.
@LantaoJin can u plz add here a result printout of a running of the TPCHQueryITSuite
There was a problem hiding this comment.
The current suite just check the generated code (Spark whole stage codegen) for all 22 PPL queries can be properly compiled. The output shows the codegen time and execution time. They are not stable which depends on hardware. So there is no input data required for this PR. This PR is just for functionality coverage as a test suite.
Later I will create another issue for benchmarking.
YANG-DB
approved these changes
Nov 6, 2024
kenrickyap
pushed a commit
to Bit-Quill/opensearch-spark
that referenced
this pull request
Dec 11, 2024
* Add TPC-H PPL query suite Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix failure of loading resources Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix data_add() Signed-off-by: Lantao Jin <ltjin@amazon.com> * enable q21 and add docs Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add TPC-H PPL query suite for
ensure there is no performance regressionRelated Issues
Resolves #806
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.