Fix CI failed related to query_177 #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <penghuo@gmail.com>
penghuo
requested review from
dai-chen,
mengweieric,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger,
LantaoJin and
ykmr1224
as code owners
YANG-DB
approved these changes
Feb 15, 2025
|
@normanj-bitquill i remove the line in query_177.results which country=USA, which is not expected as PPL query is where country != "USA". |
dai-chen
approved these changes
Feb 17, 2025
| @@ -196,6 +196,20 @@ class FlintQueryCompilerSuite extends FlintSuite { | |||
| assertResult("")(query) | |||
| } | |||
|
|
|||
| test( | |||
| "Bug fix, https://github.com/opensearch-project/opensearch-spark/actions/runs/13338348402/job/37258321066?pr=1052 ") { | |||
There was a problem hiding this comment.
The job log will be gone after retention period?
Signed-off-by: Peng Huo <penghuo@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
Signed-off-by: Peng Huo <penghuo@gmail.com> (cherry picked from commit c252899) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
Feb 25, 2025
(cherry picked from commit c252899) Signed-off-by: Peng Huo <penghuo@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOT "textField" = "literalString". It should not be push down to DSL.Related Issues
Fix Query_177 failure.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.