-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency org.apache.lucene:lucene-core to v9.5.0 #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like a system where we stay in sync with OpenSearch core version. @saratvemulapalli @ryanbogan is dependency version compatibility part of your versioning work/
76c9fa0
to
b0bec61
Compare
Thats a good point. Its not part of #337. But this is a solved problem for plugins. We could use gradle[1] [1] https://docs.gradle.org/current/userguide/platforms.html#sub:central-declaration-of-dependencies |
|
@dbwiddis taking a look at this: I dont think SDK has any dependencies on lucene at this point[1]. |
Might be needed for AnalysisPlugin (AnalysisExtension) migration. |
So yes it's definitely going to be needed for I'm ok with removing it now, if the long term plan is to add it back via a dependency catalog per your suggestion. |
b0bec61
to
7d83eba
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #388 +/- ##
=========================================
Coverage 62.32% 62.32%
Complexity 159 159
=========================================
Files 30 30
Lines 730 730
Branches 20 20
=========================================
Hits 455 455
Misses 266 266
Partials 9 9 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1db555e
to
38b98e6
Compare
38b98e6
to
2074f46
Compare
b091d49
to
23f7414
Compare
95f7c34
to
658540b
Compare
658540b
to
04cfa20
Compare
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
04cfa20
to
72cf163
Compare
We have removed lucene here: #465. Closing this PR. |
This PR contains the following updates:
9.4.2
->9.5.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.