diff --git a/build.gradle b/build.gradle index 71a05c05..7bc05a88 100644 --- a/build.gradle +++ b/build.gradle @@ -79,7 +79,7 @@ dependencies { implementation("org.opensearch:opensearch:${opensearchVersion}") implementation("org.apache.logging.log4j:log4j-api:${log4jVersion}") implementation("org.apache.logging.log4j:log4j-core:${log4jVersion}") - implementation ("org.opensearch.client:opensearch-rest-high-level-client:${opensearchVersion}") + implementation("org.opensearch.client:opensearch-rest-high-level-client:${opensearchVersion}") implementation("org.opensearch.client:opensearch-rest-client:${opensearchVersion}") implementation("org.opensearch.client:opensearch-java:${opensearchVersion}") implementation("org.opensearch.plugin:transport-netty4-client:${opensearchVersion}") diff --git a/src/main/java/org/opensearch/sdk/SDKClient.java b/src/main/java/org/opensearch/sdk/SDKClient.java index bcb729a8..ed2790c3 100644 --- a/src/main/java/org/opensearch/sdk/SDKClient.java +++ b/src/main/java/org/opensearch/sdk/SDKClient.java @@ -41,7 +41,7 @@ */ public class SDKClient { private OpenSearchClient javaClient; - private RestClient restClient = null; + private RestClient restClient; private RestHighLevelClient highLevelClient; private RestClientBuilder builder(String hostAddress, int port) { @@ -77,7 +77,7 @@ public TlsDetails create(final SSLEngine sslEngine) { * Creates OpenSearchClient for SDK. It also creates a restClient as a wrapper around Java OpenSearchClient * @param hostAddress The address of OpenSearch cluster, client can connect to * @param port The port of OpenSearch cluster - * @return SDKClient which is internally an OpenSearchClient. The user is responsible for calling {@link #doCloseRestClient()} when finished with the client + * @return The SDKClient implementation of OpenSearchClient. The user is responsible for calling {@link #doCloseJavaClient()} when finished with the client */ public OpenSearchClient initializeJavaClient(String hostAddress, int port) { RestClientBuilder builder = builder(hostAddress, port); @@ -101,7 +101,7 @@ public OpenSearchClient initializeJavaClient(String hostAddress, int port) { * Creates High Level Rest Client for SDK. * @param hostAddress The address of OpenSearch cluster, client can connect to * @param port The port of OpenSearch cluster - * @return SDKClient which is internally an RestHighLevelClient. The user is responsible for calling {@link #doCloseRestClient()} when finished with the client + * @return The SDKClient implementation of RestHighLevelClient. The user is responsible for calling {@link #doCloseHighLevelClient()} when finished with the client */ public RestHighLevelClient initializeRestClient(String hostAddress, int port) { RestClientBuilder builder = builder(hostAddress, port); @@ -115,7 +115,7 @@ public RestHighLevelClient initializeRestClient(String hostAddress, int port) { * * @throws IOException if closing the restClient fails */ - public void doCloseRestClient() throws IOException { + public void doCloseJavaClient() throws IOException { if (restClient != null) { restClient.close(); } diff --git a/src/test/java/org/opensearch/sdk/TestSDKClient.java b/src/test/java/org/opensearch/sdk/TestSDKClient.java index 4d75344c..19c9e7cf 100644 --- a/src/test/java/org/opensearch/sdk/TestSDKClient.java +++ b/src/test/java/org/opensearch/sdk/TestSDKClient.java @@ -40,7 +40,7 @@ public void testCreateJavaClient() throws Exception { ) ); - sdkClient.doCloseRestClient(); + sdkClient.doCloseJavaClient(); } @Test