Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CI #267

Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Feb 6, 2025

Description

On top of #266.

  • Fixes caching to allow switching JDKs.
  • Downgrades Faraday, the issue of typhoeus is likely some incompatibility with Faraday 2.x, but that project has been dead for 3 years or so.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The workflow missed `sudo apt-get install libcurl4-openssl-dev` to install `curb` on ubuntu.

Signed-off-by: Theo Truong <theotr@amazon.com>
@dblock dblock force-pushed the nhtruong-fix/workflows/generate_api branch 2 times, most recently from 817016e to 86109f1 Compare February 6, 2025 13:37
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the nhtruong-fix/workflows/generate_api branch from 86109f1 to 95ab937 Compare February 6, 2025 13:40
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the nhtruong-fix/workflows/generate_api branch 6 times, most recently from ba75eb5 to 19e13ae Compare February 6, 2025 14:29
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the nhtruong-fix/workflows/generate_api branch from 19e13ae to 28b773a Compare February 6, 2025 14:42
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the nhtruong-fix/workflows/generate_api branch from eea444f to 2408436 Compare February 6, 2025 14:47
@dblock dblock changed the title Nhtruong fix/workflows/generate api Fix: CI Feb 6, 2025
@dblock dblock marked this pull request as ready for review February 6, 2025 15:08
@nhtruong
Copy link
Collaborator

nhtruong commented Feb 6, 2025

I don't see where Typhoeus downgraded comparing to #266. Not sure how the Unreleased OS specs pass in this PR but not #266. But it's working so 🤷

@nhtruong nhtruong merged commit d081e8c into opensearch-project:main Feb 6, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants