Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed generate_api workflow #266

Closed

Conversation

nhtruong
Copy link
Collaborator

@nhtruong nhtruong commented Feb 3, 2025

The workflow missed sudo apt-get install libcurl4-openssl-dev to install curb on ubuntu.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dblock
dblock previously approved these changes Feb 3, 2025
@dblock
Copy link
Member

dblock commented Feb 3, 2025

You also need to update some gradle/JDK versions to match OpenSearch.

@nhtruong nhtruong force-pushed the fix/workflows/generate_api branch from 45f89a4 to 692eb0e Compare February 3, 2025 23:54
@nhtruong nhtruong marked this pull request as draft February 3, 2025 23:55
@nhtruong nhtruong marked this pull request as ready for review February 3, 2025 23:56
The workflow missed `sudo apt-get install libcurl4-openssl-dev` to install `curb` on ubuntu.

Signed-off-by: Theo Truong <theotr@amazon.com>
@nhtruong nhtruong force-pushed the fix/workflows/generate_api branch from 18468a1 to ab102de Compare February 4, 2025 00:41
#
Signed-off-by: Theo Truong <theotr@amazon.com>
#
Signed-off-by: Theo Truong <theotr@amazon.com>
#
Signed-off-by: Theo Truong <theotr@amazon.com>
#
Signed-off-by: Theo Truong <theotr@amazon.com>
#
Signed-off-by: Theo Truong <theotr@amazon.com>
#
Signed-off-by: Theo Truong <theotr@amazon.com>
#
Signed-off-by: Theo Truong <theotr@amazon.com>
#
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
@dblock dblock mentioned this pull request Feb 6, 2025
@dblock
Copy link
Member

dblock commented Feb 6, 2025

@nhtruong Downgrading Faraday worked around the issue, see #267. The typhoeus project hasn't been alive for almost 3 years so I think it's time to let it go. I'd eventually rip it out of the codebase.

@nhtruong nhtruong closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants