-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard maven publish to 1-click release process #546
Conversation
Signed-off-by: Rishabh Singh <sngri@amazon.com>
cc: @gaiksaya Please take a look. |
@rishabh6788, Our gradle project is within a sub directory TrafficCapture that I think needs to be specified. See AndreKurait@ebf6b5c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs changes on github release drafter as well with right gradle command to bundle the artifact.
Do we still need to publish to artifacts.opensearch.org? Looks like the artifact was never released https://build.ci.opensearch.org/view/Release/job/opensearch-migrations-release/
If yes, in that case we need a mechanism to distinguish what needs to be published on maven and what needs to be published on S3
Yes, we want to start publishing to artifacts as well. Let me know what change needs to be made to the gradle or github if i can help |
6e1eb5a
to
ff64077
Compare
@gaiksaya As discussed I have moved the standard release pipeline logic into opensearch-migrations repo jenkinsfile. I have also updated the release-drafter workflow to generate maven jars and upload it to draft release. Please review the PR carefully and provide feedback. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
============================================
- Coverage 76.64% 76.54% -0.10%
+ Complexity 1414 1408 -6
============================================
Files 155 155
Lines 6033 6033
Branches 543 543
============================================
- Hits 4624 4618 -6
- Misses 1044 1049 +5
- Partials 365 366 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Add
publishToMaven
method to 1-click release job.I have set the auto-publishing to false to fist test if everything looks correct.
Once verified will set it to
true
.Issues Resolved
opensearch-project/opensearch-build#4592
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.