Adding support for docvalue_fields in msearch #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankit Jain <akjain@amazon.com>
jainankitk
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
Signed-off-by: Ankit Jain <akjain@amazon.com>
Xtansia
requested changes
Feb 13, 2025
|
|
||
| MsearchResponse<ShopItem> response = sendMSearchRequest(index, List.of(sortedItemsQuery)); | ||
| assertEquals(1, response.responses().size()); | ||
| assertEquals(3, response.responses().get(0).result().hits().hits().size()); |
There was a problem hiding this comment.
Integration tests are failing on the .result() call as the response is a failure for some reason
There was a problem hiding this comment.
Fixed the integration tests, essentially doc value fields are not allowed on text fields (name). Changing that to quantity fixed the issue
Signed-off-by: Ankit Jain <akjain@amazon.com>
Xtansia
approved these changes
Feb 13, 2025
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-java/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/opensearch-java/backport-2.x
# Create a new branch
git switch --create backport/backport-1429-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0521c3c595e886dc0119ea3f652d48a5da43aaea
# Push it to GitHub
git push --set-upstream origin backport/backport-1429-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-java/backport-2.xThen, create a pull request where the |
|
@jainankitk Could you please follow the above instructions to backport this PR to 2.x? |
jainankitk
added a commit
to jainankitk/opensearch-java
that referenced
this pull request
Feb 13, 2025
* Adding support for docvalue_fields in msearch Signed-off-by: Ankit Jain <akjain@amazon.com> * Add changelog and spotless fixes Signed-off-by: Ankit Jain <akjain@amazon.com> * Fixing integration test failures Signed-off-by: Ankit Jain <akjain@amazon.com> --------- Signed-off-by: Ankit Jain <akjain@amazon.com> (cherry picked from commit 0521c3c)
|
jainankitk
added a commit
to jainankitk/opensearch-java
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Ankit Jain <akjain@amazon.com>
Xtansia
pushed a commit
that referenced
this pull request
Feb 13, 2025
* Adding support for docvalue_fields in msearch Signed-off-by: Ankit Jain <akjain@amazon.com> * Add changelog and spotless fixes Signed-off-by: Ankit Jain <akjain@amazon.com> * Fixing integration test failures Signed-off-by: Ankit Jain <akjain@amazon.com> --------- Signed-off-by: Ankit Jain <akjain@amazon.com> (cherry picked from commit 0521c3c)
Xtansia
pushed a commit
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for docvalue_fields in msearch
Issues Resolved
#1428
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.