Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Search request params missing in Java client #1025

Closed
dzane17 opened this issue Jun 11, 2024 · 1 comment · Fixed by #1036
Closed

[FEATURE] Search request params missing in Java client #1025

dzane17 opened this issue Jun 11, 2024 · 1 comment · Fixed by #1036
Assignees
Labels
bug Something isn't working

Comments

@dzane17
Copy link
Contributor

dzane17 commented Jun 11, 2024

Is your feature request related to a problem?

Java client does not support some request parameters which were recently added in core such as search_pipeline, phase_took.

What solution would you like?

Crosscheck current params and add support for those missing.

What alternatives have you considered?

N/A

Do you have any additional context?

https://github.com/opensearch-project/OpenSearch/blob/ab7e914c3956ac206cf269ca345574882770a283/server/src/main/java/org/opensearch/rest/action/search/RestSearchAction.java#L150

@dzane17 dzane17 added enhancement New feature or request untriaged labels Jun 11, 2024
@dzane17 dzane17 self-assigned this Jun 11, 2024
@dblock
Copy link
Member

dblock commented Jun 11, 2024

FYI, we have recently merged a beginning of a code generator that aims to resolve this entire class of problems (#366). There are a few things you can do to help:

  1. Ensure that the specification for these APIs in https://github.com/opensearch-project/opensearch-api-specification is correct, and add tests for them in that repo.
  2. Write tests in this repo for the scenarios that are broken like the ones you're reporting and manually fix any of these bugs.

The combination will ensure that as we switch to the generator we're not introducing regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants