Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow Framework] Add containsModels param to handle custom/empty template #1713

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

ohltyler
Copy link
Member

Description

Add containsModels param to handle custom/empty template. We don't want to search for models for this template, which does not require one.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
Copy link
Member Author

Result from running tests on a template with models, and one without:

  Creating Workflows Using Various Methods
    - Import workflow with valid configuration
    - Attempt to import workflow with invalid configuration
    - Create workflow using semantic search template
    - Create workflow from hybrid search template
    ✓ Create workflow from multimodal template (229902ms)
    ✓ Create workflow from custom template (154730ms)


  2 passing (7m)
  4 pending


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        6                                                                                │
  │ Passing:      2                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      4                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     6 minutes, 44 seconds                                                            │
  │ Spec Ran:     plugins/dashboards-flow-framework/create_workflow_spec.js                        │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Video)

  -  Started processing:  Compressing to 32 CRF                                                     
    Compression progress:  71%
  -  Finished processing: /Users/ohltyler/workspace/opensearch/3.0/opensearch-dashboa   (21 seconds)
                          rds-functional-test/cypress/videos/plugins/dashboards-flow-               
                          framework/create_workflow_spec.js.mp4                                     

    Compression progress:  100%

====================================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/dashboards-flow-framework/c      06:44        6        2        -        4        - │
  │    reate_workflow_spec.js                                                                      │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        06:44        6        2        -        4        -  

@ashwin-pc ashwin-pc merged commit 2b57298 into opensearch-project:main Feb 13, 2025
42 of 44 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 13, 2025
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 2b57298)
@ohltyler ohltyler deleted the fix-flow-it-6 branch February 13, 2025 19:40
ohltyler added a commit that referenced this pull request Feb 13, 2025
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 2b57298)

Co-authored-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants