Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable video recording in Windows due to ffmpeg crash #1069

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Feb 6, 2024

Description

Disable video recording in Windows due to ffmpeg crash
Also remove a rm issue causing failure due to file not exist raised in #988.

Issues Resolved

opensearch-project/opensearch-build#4427

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@tianleh
Copy link
Member

tianleh commented Feb 6, 2024

Is the picture uploading still working? Just want to make sure that it still has some traces for developers to debug

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Feb 6, 2024

Is the picture uploading still working? Just want to make sure that it still has some traces for developers to debug

This only disable the video recording, did not touch the picture functionality, only on windows.

@peterzhuamazon peterzhuamazon added the bug Something isn't working label Feb 6, 2024
@peterzhuamazon peterzhuamazon merged commit 607560d into opensearch-project:main Feb 6, 2024
40 checks passed
@peterzhuamazon peterzhuamazon deleted the windows-disable-video branch February 6, 2024 19:25
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1069-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 607560defc1db1e235f47b4578b41c89b3c39c77
# Push it to GitHub
git push --set-upstream origin backport/backport-1069-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-1069-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1069-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 607560defc1db1e235f47b4578b41c89b3c39c77
# Push it to GitHub
git push --set-upstream origin backport/backport-1069-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1069-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 backport 2.x bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants