-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable video recording in Windows due to ffmpeg crash #1069
Disable video recording in Windows due to ffmpeg crash #1069
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
c1a5977
to
76f895b
Compare
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Is the picture uploading still working? Just want to make sure that it still has some traces for developers to debug |
This only disable the video recording, did not touch the picture functionality, only on windows. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1069-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 607560defc1db1e235f47b4578b41c89b3c39c77
# Push it to GitHub
git push --set-upstream origin backport/backport-1069-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1069-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 607560defc1db1e235f47b4578b41c89b3c39c77
# Push it to GitHub
git push --set-upstream origin backport/backport-1069-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Description
Disable video recording in Windows due to ffmpeg crash
Also remove a rm issue causing failure due to file not exist raised in #988.
Issues Resolved
opensearch-project/opensearch-build#4427
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.