-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workflow): paths-filter error on push event #1017
fix(workflow): paths-filter error on push event #1017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be replaced with https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/manifests.yml#L6-L9 I think.
Nice! Thanks for the suggestion, will try that github flow builtin solution |
run checkout action before paths-filter Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
87ca867
to
e38a899
Compare
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks for resolving #1108 casually.
refactor to use Github action builtin path filter --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit 9f0d25d)
Resolved
#993
#1108
Removed
dorny/paths-filter
action and use GitHub workflow builtin path filterDescription
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.