feat: Setup assistant agent & workflow file. #1002

SuZhou-Joe · 2024-01-19T02:05:18Z

Description

We are going to onboard a new dashboards plugin dashboards-assistant to FTRepo, this is the initial PR to setup basic workflow file and agent. Test cases will be included in following PRs.

Issues Resolved

opensearch-project/opensearch-build#4322

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

wanglam · 2024-01-19T02:24:11Z

cypress/integration/plugins/dashboards-assistant/basic_spec.js

Since the dashboards-assistant plugin was experimental by default, shall we add a flag to disabled the functional tests by default?

I am not sure about this part, I thought experimental means it should be controlled behind a feature flag. For integration test, no matter experimental or not, they all should be triggered if test cases changed.

SuZhou-Joe · 2024-01-19T02:46:51Z

You can find success log in SuZhou-Joe#2, #7121 artifact failed to include assistant-dashboards, 7122 includes.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe · 2024-01-22T08:39:40Z

test.log
Above is the success log.

SuZhou-Joe · 2024-01-22T08:41:05Z

ml-commons did a refactor on its memory APIs, so test won't pass based on latest OSD main. Need to wait for PR: opensearch-project/dashboards-assistant#106 to be merged.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

wanglam · 2024-01-23T07:22:15Z

cypress/utils/plugins/dashboards-assistant/commands.js

+
+Cypress.Commands.add('startDummyServer', () => {
+  // Not a good practice to start a server inside Cypress https://docs.cypress.io/guides/references/best-practices#Web-Servers
+  // But in out case, we need to reuse release e2e template and let's make it a tradeoff.


Shall we add this startDummyServer in the package.json or workflow files manually? Just wondering if there are some ports conflicts after call this command for many times.

add startDummyServer to workflow files manually

We can not because by leveraging the release E2E tremplate, the test-cmd will be passed to Cypress-test step and that step won't accept & operators in its input.

there are some ports conflicts after call this command for many times

yes it will, we've add stopDummyServer in our test command and that should address the ports conflict issue.

Can we use like command-prefix in the cypress-io/github-action@v2? The nohup may not work in the windows. Another concern was not sure if the stopDummyServer is a sync method. Even it's a sync method, it will close dummy server for other tests, if we run tests in parallel.

Using command-prefix

It means we need to add a new input in release e2e template, I do not think it worthy for only a single customized plugin. Additionally, if we add some new logic in e2e template, I am not sure build team's e2e test flow will follow the logic.

The nohup may not work in the windows

I did some test in a windows machine using git bash, it supports nohup commands. And for github CI image windows-latest, it is using bash as well. But sure let me do a test to run these commands on github CI image.

close dummy server for other tests

Yeah I take this case into consideration so I moved setup work before all of the test cases get triggered in support/index.js.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: enable setup Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: using a external mock service to mock a dummy LLM Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use local dummy server Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add some basic test cases Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: run with server Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use ml-commons api to setup test agent manually Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove flow_framework.enabled config Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove visualization as skills repo is not bundled in snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add flag config Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize stop command Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move setup steps to support/index.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit cd1dd23)

* feat: Setup assistant agent & workflow file. (#1002) * feat: enable setup Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: using a external mock service to mock a dummy LLM Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use local dummy server Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add some basic test cases Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: run with server Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use ml-commons api to setup test agent manually Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove flow_framework.enabled config Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove visualization as skills repo is not bundled in snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add flag config Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize stop command Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move setup steps to support/index.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit cd1dd23) * fix: add wait Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>

feat: enable setup

166d6dd

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe requested review from xluo-aws, Hailong-am, ruanyl, wanglam and raintygao as code owners January 19, 2024 02:05

wanglam reviewed Jan 19, 2024

View reviewed changes

ruanyl approved these changes Jan 19, 2024

View reviewed changes

wanglam approved these changes Jan 19, 2024

View reviewed changes

SuZhou-Joe added 7 commits January 19, 2024 17:31

feat: using a external mock service to mock a dummy LLM

74e3f5c

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: use local dummy server

7017eae

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add some basic test cases

a66ac5d

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: run with server

d51d244

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: use ml-commons api to setup test agent manually

94f53ec

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove flow_framework.enabled config

34ea933

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove visualization as skills repo is not bundled in snapshot

53c3d39

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add flag config

e2f88fd

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

Hailong-am approved these changes Jan 23, 2024

View reviewed changes

wanglam reviewed Jan 23, 2024

View reviewed changes

feat: optimize stop command

3b56c83

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

raintygao approved these changes Jan 23, 2024

View reviewed changes

feat: move setup steps to support/index.js

2e98ab5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe merged commit cd1dd23 into opensearch-project:main Jan 23, 2024
37 of 38 checks passed

raintygao mentioned this pull request Jan 23, 2024

[On-boarding]: dashboards-assistant plugin opensearch-project/opensearch-build#4322

Closed

SuZhou-Joe added backport 2.x v2.12.0 labels Jan 30, 2024

opensearch-trigger-bot bot mentioned this pull request Jan 30, 2024

[Backport 2.x] feat: Setup assistant agent & workflow file. #1014

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Setup assistant agent & workflow file. #1002

feat: Setup assistant agent & workflow file. #1002

SuZhou-Joe commented Jan 19, 2024 •

edited

Loading

wanglam Jan 19, 2024

SuZhou-Joe Jan 19, 2024

SuZhou-Joe commented Jan 19, 2024 •

edited

Loading

SuZhou-Joe commented Jan 22, 2024

SuZhou-Joe commented Jan 22, 2024

wanglam Jan 23, 2024

SuZhou-Joe Jan 23, 2024 •

edited

Loading

wanglam Jan 23, 2024

SuZhou-Joe Jan 23, 2024 •

edited

Loading

feat: Setup assistant agent & workflow file. #1002

feat: Setup assistant agent & workflow file. #1002

Conversation

SuZhou-Joe commented Jan 19, 2024 • edited Loading

Description

Issues Resolved

Check List

wanglam Jan 19, 2024

Choose a reason for hiding this comment

SuZhou-Joe Jan 19, 2024

Choose a reason for hiding this comment

SuZhou-Joe commented Jan 19, 2024 • edited Loading

SuZhou-Joe commented Jan 22, 2024

SuZhou-Joe commented Jan 22, 2024

wanglam Jan 23, 2024

Choose a reason for hiding this comment

SuZhou-Joe Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

wanglam Jan 23, 2024

Choose a reason for hiding this comment

SuZhou-Joe Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

SuZhou-Joe commented Jan 19, 2024 •

edited

Loading

SuZhou-Joe commented Jan 19, 2024 •

edited

Loading

SuZhou-Joe Jan 23, 2024 •

edited

Loading

SuZhou-Joe Jan 23, 2024 •

edited

Loading