Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version increment workflow to remove main/3.x updates #5353

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peterzhuamazon
Copy link
Member

Description

Update version increment workflow to remove main/3.x updates

Issues Resolved

#3747
As of now 3.x version increment are crafted specifically to support qualifiers with a lot of tweaks from plugin side.
Disable this for now until after GA so we do not receive PRs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (4960862) to head (ef31f83).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5353   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         202      202           
  Lines        7043     7043           
=======================================
  Hits         6483     6483           
  Misses        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -53,11 +53,8 @@ jobs:
- {repo: opensearch-remote-metadata-sdk}
- {repo: opensearch-learning-to-rank-base}
branch:
- 2.x
- main
Copy link
Member

@prudhvigodithi prudhvigodithi Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still keep main right Peter as it will handle future version increments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In Review
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants