Add release-chores workflow #5325
Conversation
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
requested review from
dblock,
peterzhuamazon,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5325 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 202 202
Lines 7042 7042
=======================================
Hits 6482 6482
Misses 560 560 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
| agent { | ||
| docker { | ||
| label 'Jenkins-Agent-AL2023-X64-M54xlarge-Docker-Host' | ||
| image 'opensearchstaging/ci-runner:ci-runner-centos7-opensearch-build-v3' |
There was a problem hiding this comment.
This is severely outdated can we use the rockylinux8 one?
There was a problem hiding this comment.
Sure can you let me know the exact image?
There was a problem hiding this comment.
There was a problem hiding this comment.
Please test this image beforehand now sure if it has all the deps you need.
There was a problem hiding this comment.
This image does not have recent version of curl for awssig4 option.
curl: option --aws-sigv4: is unknown
curl: try 'curl --help' or 'curl --manual' for more information
Is this image fine? https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/integ-test-notification.jenkinsfile#L20
Metrics cluster needs sigv4 option.
There was a problem hiding this comment.
Yeah AL2 is fine for the moment.
There was a problem hiding this comment.
Tested with above image. Works as expected
gaiksaya#49 (comment)
Thanks!
| ) | ||
| string( | ||
| name: 'RELEASE_CHORE', | ||
| description: "Required: What release chore you wanna do? e.g: 'add_rc_details_comment'", |
There was a problem hiding this comment.
Where can we find these entries? Is a choice parameter better here?
There was a problem hiding this comment.
Thought of adding the choice parameter but I believe executing multiple tasks at once makes sense. I'll look into multi-select parameter option in the future. https://plugins.jenkins.io/multiselect-parameter/
For now you can find the options in the parameter description.
| } | ||
| steps { | ||
| script { | ||
| addRcDetailsComment( |
There was a problem hiding this comment.
Wonder will this library help collapse/cross the previous RC comments?
There was a problem hiding this comment.
Nope it won't. We dont do that even today. Check the sample comment in the PR description. This will just add new RC comment. Wont touch anything else.
There was a problem hiding this comment.
I think this would be a nice-to-have feature if feasible. We used to do it manually at least update the previous RC comments to indicate they are no longer valid. We've seen issues when teams were not using the latest RC.
Not a blocker for this PR but maybe we can keep track of this as enhancement.
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Description
This workflow will host all the minute release chores that are run manually today starting with adding rc details to the GH issue as a comment, checking the docker scan results. Sample comment.
The future plan is to enhance this workflow to add more chores such as checking release notes and updating entrance criteria accordingly, updating exit criterias, etc.
Issues Resolved
closes #5022
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.