-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor integ-test notification #5081
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
* | ||
* The OpenSearch Contributors require contributions made to | ||
* this file be licensed under the Apache-2.0 license or a | ||
* compatible open source license. | ||
*/ | ||
|
||
lib = library(identifier: 'jenkins@7.0.0', retriever: modernSCM([ | ||
$class: 'GitSCMSource', | ||
remote: 'https://github.com/opensearch-project/opensearch-build-libraries.git', | ||
])) | ||
|
||
|
||
pipeline { | ||
agent { label 'Jenkins-Agent-Ubuntu2004-X64-M58xlarge-Single-Host' } | ||
options { | ||
timeout(time: 1, unit: 'HOURS') | ||
buildDiscarder(logRotator(daysToKeepStr: '90')) | ||
} | ||
triggers { | ||
parameterizedCron(''' | ||
H */6 * * * %INPUT_MANIFEST=2.17.2/opensearch-2.17.2.yml | ||
H */6 * * * %INPUT_MANIFEST=2.18.0/opensearch-2.18.0.yml | ||
H */6 * * * %INPUT_MANIFEST=3.0.0/opensearch-3.0.0.yml | ||
Comment on lines
+24
to
+26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shall we update the input manifest generation workflow to update this section alongside check-for-build as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes! Will take that up in next iteration. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you create an issue for that since you seems to close #5038 in this PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done #5083 |
||
''') | ||
} | ||
parameters { | ||
string( | ||
name: 'INPUT_MANIFEST', | ||
description: 'Input manifest under the manifests folder, e.g. 2.0.0/opensearch-2.0.0.yml.', | ||
trim: true | ||
) | ||
} | ||
stages { | ||
stage('Update integ tests failure issues') { | ||
steps { | ||
script { | ||
updateIntegTestFailureIssues( | ||
inputManifestPath: "manifests/${INPUT_MANIFEST}" | ||
) | ||
} | ||
} | ||
} | ||
} | ||
post() { | ||
always { | ||
script { | ||
postCleanup() | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not use this as this is specifically for gradle check and only runs once and delete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any recommendation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to use ubuntu then use the docker builder one
If not, then use a generic x64 docker host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to
Jenkins-Agent-AL2023-X64-C54xlarge-Docker-Host
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you are going to run directly on agent node without docker container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Followed the same patter we are using for https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/gradle/gradle-check-flaky-test-issue-creation.jenkinsfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding @prudhvigodithi to take a look to update that jenkinsfile to use other runners.
I still think using a docker container here is more clean.
As using the agent might have cleanup issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used
Jenkins-Agent-Ubuntu2004-X64-M58xlarge-Single-Host
in jenkinsfile https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/gradle/gradle-check-flaky-test-issue-creation.jenkinsfile because:gradle-check-flaky-test-issue-creation.jenkinsfile
comes under the same family gradle-check hence used the same.Jenkins-Agent-Ubuntu2004-X64-M58xlarge-Single-Host
because of the latestcurl
version which supports--aws-sigv4
flag.But looks to me like this
Jenkins-Agent-AL2023-X64-C54xlarge-Docker-Host
(coming from https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L876-L881) also has that latestcurl
version that supports--aws-sigv4
flag.